Thank you for your attention, I will upgrade my infrastructure to the 7.8 version asap and keep you in touch if I still have problems.
For the guide, here is what I remember.
I think the step 1 on configuring the AD instances is just fine.
In the step 2 about NetScalers, a CloudFormation template is missing. You provide a CloudFormation template that launches a NetScaler, and another one that launches 2 NetScalers (One in each AZ) and optionally 2 CloudBridges. This second template is not available, the link is outdated.
There is also something that is not told in your guide, it is to add 10.16.9.11 and 10.16.1.10 as Subnet IP for NS1, and 10.16.10.11 and 10.16.2.10 as Subnet IP for NS2. I stuggled with that.
For the step 3, I also struggled a lot with the CloudFormation template. I remember that the section about Stripping the disks is not working because your are starting at index 0 instead of 1 with a "select disk=0". (See below the modified version I created)
"select disk=1 ",
"select partition 1 ",
"delete partition ",
"select disk=2 ",
"select partition 1 ",
So here you just need to increment the disks number by 1.
In my own implementation, I did not want to use an Enterprise version of SQL Server as this is quite costly, so I guess it could be good if you can provide an option to use SQL Server Standard with database mirroring or something else instead of AlwaysOn Availability Groups (which requires enterprise version), for small deployments like mine who cannot afford an Enterprise version. (I think I saw somewhere that the 2016 version will provide AlwaysOn for 2 nodes in the standard version, so that could solve the problem once it is released)
Finally for this step, I also remember that this is not a really stable deployment as it sometimes "randomly" fails. I needed to launch the CloudFormation template a few times before it worked. I do not exactly remember why, but I think it was also related to the disks, and I think I increased the waitAfterCompletion value somewhere to make it work more often.
For the step 4, I just remember having to manually join the second Delivery Controller to the first Delivery Controller site, because the CloudFormation template did not do it correctly. I think that's all for this step.
For step 5, I remember that I struggled with the Security Groups not being setup correctly.
And finally for the step 6, my issue is described previously in this post.
More generally, the default values/descriptions for CloudFormation parameters provided in the tables of your guide are not always corresponding to the actual parameters of the scripts. I remember that I struggled quite a lot with the right IP addresses to assign to the NetScaler instances, as it was different in your guide and on the templates.
Some of the Security Groups that are being created are missing some rules, I am sorry I do not remember each one. I just wrote that somewhere if it can be useful -> "Add 10.16.7.0/24 and 10.16.8.0/24 to the StoreFront Security group for ports 808. (To enable replication between the 2 StoreFront instances). Add the 3008-3011 TCP port range to destination Anywhere to the NetScaler public security group, to enable synchronisation between NetScaler appliances."
I think that is pretty much most of the issues I encountered during the deployment. Most of them are easy fixes, but when you are a newbie like me, it can take a loooooot of time to fix them. I probably wasted a lot of time and money in this deployment because of the issues found in this guide and that's not cool but at least it made me understand every component of the infrastructure perfectly which is cool.
So if you need any other details please do not hesitate to ask me and I will try to help as much as I can.
Thank you again.